Skip to content

feat(deploy): refuse a commit whose ci-unified run is not green (#1550) - #1948

Merged
groupsky merged 6 commits into
masterfrom
fix/1550-deploy-requires-green-ci
Nov 11, 2026
Merged

groupsky merged 6 commits into
masterfrom
fix/1550-deploy-requires-green-ci

Conversation

@groupsky

@groupsky groupsky commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Refs #1550

deploy.sh checks that the commit's ci-unified run on GitHub is green before the snapshot. A red (or still running) run stops the deploy; --allow-red-ci overrides it.

Choice: option 2 from the issue. It is the leanest: CI does not change, so stage 3 still pushes SHA tags before the tests and the #1546 force_rebuild recovery works as before. The gate sits where the deploy decision is made. It reads the public GitHub API with curl (the repo is public, so no token is needed on routy).

Progress

Tests: scripts/tests/deploy-flow.bats (7 new cases: red run stops, a green pull request run does not count, --allow-red-ci deploys, running run is waited for, green force_rebuild beside a red run deploys, GitHub down stops at the deadline, unknown tag refused). All 271 bats cases pass locally.

@groupsky
groupsky marked this pull request as ready for review November 11, 2026 12:38
@groupsky
groupsky merged commit 3bf5279 into master Nov 11, 2026
25 checks passed
@groupsky
groupsky deleted the fix/1550-deploy-requires-green-ci branch November 11, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant