Repository navigation
feat(deploy): refuse a commit whose ci-unified run is not green (#1550) - #1948
Merged
Merged
Conversation
groupsky
marked this pull request as ready for review
November 11, 2026 12:38
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1550
deploy.shchecks that the commit'sci-unifiedrun on GitHub is green before the snapshot. A red (or still running) run stops the deploy;--allow-red-cioverrides it.Choice: option 2 from the issue. It is the leanest: CI does not change, so stage 3 still pushes SHA tags before the tests and the #1546
force_rebuildrecovery works as before. The gate sits where the deploy decision is made. It reads the public GitHub API withcurl(the repo is public, so no token is needed on routy).Progress
ci-unifiedrun was red is impossible without an explicit override flag (--allow-red-ci)force_rebuildrun makes the commit deployable).github/workflows/CLAUDE.mdreflects the new ruleTests:
scripts/tests/deploy-flow.bats(7 new cases: red run stops, a green pull request run does not count,--allow-red-cideploys, running run is waited for, greenforce_rebuildbeside a red run deploys, GitHub down stops at the deadline, unknown tag refused). All 271 bats cases pass locally.