Skip to content

Fix ordering of selected versions when assembling the overlay - #46

Merged
ziopio merged 1 commit into
masterfrom
ziopio/overlay-hotfix
Jul 29, 2026
Merged

Fix ordering of selected versions when assembling the overlay#46
ziopio merged 1 commit into
masterfrom
ziopio/overlay-hotfix

Conversation

@ziopio

@ziopio ziopio commented Jul 28, 2026

Copy link
Copy Markdown
Member

The function collect_overlay was ordering the directory list but it was also missing 2 things:

  • ordering directories was putting the versions in order but that pushed "common" at the end of the list
    This was hiding the next bug when just one version folder is selected:
  • select_overlay_folders was not reversing the order of the list after the tail recursion

Now instead we do:

  • list everything,
  • filter out everything that is not an otp version folder
  • order such list
  • select
  • reverse selection order (to fix ordering)
  • put "common" at the head of the list

@ziopio
ziopio requested review from maehjam and sylane July 28, 2026 15:02
@ziopio
ziopio merged commit bf30db7 into master Jul 29, 2026
11 checks passed
@ziopio
ziopio deleted the ziopio/overlay-hotfix branch July 29, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants