[ROSETTA] Keep Helm anti-affinity aligned with nameOverride

[isolomatov-gd]

src/helm-charts/rosetta-mcp-server/values.yaml hardcodes rosetta-mcp in the default anti-affinity selector, while nameOverride changes the pod label derived by the chart helpers. Render or configure the selector from the canonical name and add a Helm test for a custom nameOverride.

[github-actions]

Rosetta Triage

Classification: bug — the chart's anti-affinity selector diverges from its canonical workload label when nameOverride is set.
Priority assessment: Medium. It affects only customized deployments, but it silently removes the configured pod-spread preference and can reduce availability during a node failure.

Findings:

• rosetta-mcp.selectorLabels derives app.kubernetes.io/name from nameOverride; the Deployment and Service both use that helper.
• values.yaml instead hardcodes rosetta-mcp in the default anti-affinity match expression, so a custom override matches no workload pods.
• Helm unit tests run in CI, but tests/deployment_test.yaml has no assertion for either the affinity selector or a custom nameOverride.

Suggestions:

• Render the default anti-affinity selector from rosetta-mcp.name in a template. Do not place a Helm expression only in values.yaml, because the current toYaml rendering does not evaluate values as templates.
• Add a deployment unit test with a custom nameOverride that asserts the anti-affinity selector value. Update the nearby values comment so it states the supported behavior precisely.

Next steps: Implement the helper-based default, retain explicit affinity customization if it is an intended chart contract, and add the regression test.

Automated triage by Rosetta agent