Repository navigation
fix(ci): wait 15 minutes for npm to make a publish visible - #161
Merged
Merged
Conversation
- npm now accepts a publish before the version is visible; 1.0.0-rc.4 took nine and a half minutes, and the one-minute wait failed a release that had published correctly, skipping the GitHub release - poll the registry 90 times, ten seconds apart, instead of six - bound the step at 20 minutes, so npm's own retries and request timeouts on top of the polls cannot hold the publish concurrency group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
v1.0.0-rc.4publish (run 39379699234) went out fine, but npm took about nine and a half minutes to make the version visible. The verify step only waited a minute, so the run failed and skipped the GitHub release. Rerunning the failed job finished it.npm now says this on publish: "Your package is being processed and may take a few minutes to become available." So the wait has to be longer.
Changes
Confirm the registry has the bytes we testedpolls 90 times, ten seconds apart (15 minutes), instead of 6.timeout-minutes: 20, so npm's own retries and request timeouts can't stretch it out and hold thepublishconcurrency group.Integrity is still compared on the first lookup that returns a value, so the longer wait can't let a mismatched artifact through. Codex reviewed the loop under
bash -e, the integrity gate and rerun behaviour, and the step timeout came out of that.