feat(models): make retrieval and fusion score semantics explicit (#90) - #142
Closed
Muhammad-AbdullahGhani wants to merge 1 commit into
Closed
Muhammad-AbdullahGhani wants to merge 1 commit into
Muhammad-AbdullahGhani wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi @SaadBazaz, I have starred and forked the repo.. |
Collaborator
|
Thanks for working on this. We’re continuing with #144 for #90, so I’m closing this overlapping implementation. This version hardcodes cosine even though indexes can use other distance metrics, and adds duplicate rank and channel fields that need to stay synchronized. #144 reads the configured metric and uses the existing fields, though it still needs changes from review. If you’d like to contribute further to this issue, feel free to coordinate with @AhmedIrfan7 on #144. I’ve left specific feedback there that you could work through together. Your bounded-moment fix in #141 is merged. Thanks for following through on that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #90
Summary
Validation