Skip to content

feat(check-store): add smoke-test action and use resolve-check-config#255

Merged
damienwebdev merged 1 commit into
mainfrom
checkout-store-smoke-test
May 17, 2026
Merged

feat(check-store): add smoke-test action and use resolve-check-config#255
damienwebdev merged 1 commit into
mainfrom
checkout-store-smoke-test

Conversation

@damienwebdev
Copy link
Copy Markdown
Member

@damienwebdev damienwebdev commented May 10, 2026

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bugfix
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

check-store.yaml runs unit-test and coding-standard against every supported Magento version produced by supported-version. There is no smoke check, so a store can be lint-clean and unit-test-green yet still fail to boot. There is also no caller-facing knob to disable individual checks per-project.

Fixes: N/A

What is the new behavior?

  • Adds a smoke-test job to check-store.yaml that:
    • Brings up the full per-version service set (mysql, search, queue, cache, nginx, php-fpm) from the supported-version matrix.
    • Runs setup:install inside the php-fpm service container.
    • Configures the nginx service container against the installed Magento path.
    • Fires both page and graphql smoke probes against the running store.
  • Routes the workflow's matrix through the existing resolve-check-config action. compute_matrix now emits a single resolved output (per-job filtered matrix) and every downstream job:
    • Gates on fromJSON(...)['<job>'].enabled != false, so callers can disable a check by adding it to .github/check-store.json.
    • Pulls its strategy.matrix from resolved['<job>'].matrix, which already has each entry's services map filtered to the tiers that job needs.
  • Updates docs/workflows/check-store.md:
    • Adds the smoke-test bullet to Checks Run.
    • Adds a Configuration section documenting .github/check-store.json, including a $schema-referenced example for editor autocompletion / validation.
    • Cross-links to the resolve-check-config action README for the full config surface.

Does this PR introduce a breaking change?

  • Yes
  • No

check-store.yaml's public inputs and secrets are unchanged. The new smoke-test job runs by default; callers can opt out by adding { "jobs": { "smoke-test": false } } to .github/check-store.json.

Other information

  • Companion actions used by the new smoke-test job (setup-install, configure-service-nginx, smoke-test) are already on main; the workflow pins them to @main.
  • Per-job matrix filtering means that, for example, unit-test no longer spins up unused service containers — its matrix entries carry services: {}.

@damienwebdev damienwebdev force-pushed the checkout-store-smoke-test branch 2 times, most recently from 3c8370d to 068a762 Compare May 16, 2026 16:45
@damienwebdev damienwebdev force-pushed the checkout-store-smoke-test branch from abb939e to 7064ca7 Compare May 17, 2026 17:49
damienwebdev added a commit that referenced this pull request May 17, 2026
damienwebdev added a commit that referenced this pull request May 17, 2026
@gray-bot gray-bot mentioned this pull request May 17, 2026
@damienwebdev damienwebdev force-pushed the checkout-store-smoke-test branch from 970a0af to 19bd2f6 Compare May 17, 2026 21:23
@damienwebdev damienwebdev changed the title attempt checkout store smoke test feat(check-store): add smoke-test action and use resolve-check-config May 17, 2026
@damienwebdev damienwebdev merged commit e39dd46 into main May 17, 2026
21 checks passed
@damienwebdev damienwebdev deleted the checkout-store-smoke-test branch May 17, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant