Conversation
Contributor
|
Preview is ready. |
Contributor
|
Playwright Test Component is ready. |
- Removed the `BlogConstructorProvider.analytics` prop; analytics should now be passed through the `settings` prop on `BlogPage` and `BlogPostPage`. - Updated analytics event handling to use the new `createExtendedEvent` utility for better integration with Blog Constructor goals. - Adjusted various components (Banner, CTA, Header, Meta, etc.) to reflect the new analytics structure and ensure proper event emission. - Updated documentation to guide users on the new analytics configuration and usage. - Bumped dependencies for `@gravity-ui/page-constructor` and related packages to the latest versions.
NikitaCG
requested changes
Sep 10, 2026
| ``` | ||
|
|
||
| **!!! Important thing** - We throw analytics settings in blog constructor provide, if we need analytics from only-blog components. If we need analytics in page-constructor blocks we need to throw analytics settings in [page settings props](../containers/BlogPage/README.md) | ||
| `BlogConstructorProvider` does not provide analytics. Pass the single analytics configuration via |
Collaborator
There was a problem hiding this comment.
if does not provide, maybe we need delete this article ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.