Repository navigation
Fix callout: variables don't require a named operation - #2562
Open
rudney5000 wants to merge 1 commit into
Open
rudney5000 wants to merge 1 commit into
rudney5000 wants to merge 1 commit into
Conversation
|
@rudney5000 is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
|
martinbonnin
approved these changes
Oct 29, 2026
martinbonnin
left a comment
martinbonnin
left a comment
Contributor
There was a problem hiding this comment.
Thanks for catching this 🙏
Contributor
|
Can you sign the CLA? More info there: https://graphql.org/community/contribute/project-meetings/#sign-the-easycla |
Author
|
Done, the CLA is signed. Thanks for the review! |
Contributor
|
Thanks! I'll leave this open a few days, make sure to get other people inputs in case we're missing something but LGTM! |
saihaj
approved these changes
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The callout in the Variables section says a GraphQL document must have an operation type and name to use variables. Per the spec, only the operation type is required: anonymous operations such as
query ($id: ID!) { ... }may declare variables. Only the query shorthand cannot have variable definitions (§2.3 Document, §2.4 Operations).The callout also contradicted the "Operation name" section of the same page, which says the name is only required in multi-operation documents (see also #441).
This rewords the callout accordingly and keeps naming the operation as a recommended practice.