Skip to content

perf(pyutils): 2.5x faster natural_comparison_key (schema sort keys) #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dexhunter wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(pyutils): 2.5x faster natural_comparison_key (schema sort keys) #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/graphql/pyutils/natural_compare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
from __future__ import annotations

import re
from itertools import cycle

__all__ = ["natural_comparison_key"]

Expand All @@ -15,7 +14,9 @@ def natural_comparison_key(key: str) -> tuple:

See: https://en.wikipedia.org/wiki/Natural_sort_order
"""
return tuple(
(int(part), part) if is_digit else part
for part, is_digit in zip(_re_digits.split(key), cycle((False, True)))
)
# letters only (no decimal digits) is the common case, check it cheaply first
if type(key) is str and key.isalpha():
return (key,)
parts = _re_digits.split(key)
parts[1::2] = [(int(part), part) for part in parts[1::2]]
return tuple(parts)
Loading