Skip to content

perf(schema): reduce type checks - less rebuild time #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dexhunter wants to merge 1 commit into from
Closed

perf(schema): reduce type checks - less rebuild time #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions src/graphql/type/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,14 @@
GraphQLAbstractType,
GraphQLCompositeType,
GraphQLField,
GraphQLInputObjectType,
GraphQLInputType,
GraphQLInterfaceType,
GraphQLNamedType,
GraphQLObjectType,
GraphQLType,
get_named_type,
GraphQLUnionType,
GraphQLWrappingType,
is_input_object_type,
is_interface_type,
is_object_type,
Expand Down Expand Up @@ -739,26 +741,37 @@ def with_initial_types(cls, types: Collection[GraphQLType]) -> TypeSet:

def collect_referenced_types(self, type_: GraphQLType) -> None:
"""Recursive function supplementing the type starting from an initial type."""
named_type = get_named_type(type_)
named_type: GraphQLType | None = None
if type_:
named_type = type_
while isinstance(named_type, GraphQLWrappingType):
named_type = named_type.of_type

if named_type in self:
return

if TYPE_CHECKING:
named_type = cast("GraphQLNamedType", named_type)
self[named_type] = None

collect_referenced_types = self.collect_referenced_types
if is_union_type(named_type):
if isinstance(named_type, GraphQLUnionType):
collect_referenced_types = self.collect_referenced_types
for member_type in named_type.types:
collect_referenced_types(member_type)
elif is_object_type(named_type) or is_interface_type(named_type):
elif isinstance(named_type, (GraphQLObjectType, GraphQLInterfaceType)):
collect_referenced_types = self.collect_referenced_types
for interface_type in named_type.interfaces:
collect_referenced_types(interface_type)

for field in named_type.fields.values():
collect_referenced_types(field.type)
for arg in field.args.values():
args = field.args
if type(args) is dict and not args:
continue
for arg in args.values():
collect_referenced_types(arg.type)
elif is_input_object_type(named_type):
elif isinstance(named_type, GraphQLInputObjectType):
collect_referenced_types = self.collect_referenced_types
for field in named_type.fields.values():
collect_referenced_types(field.type)

Expand Down
Loading