Repository navigation
Cut comments from #857 that repeat the code or explain its history - #869
Merged
Merged
Conversation
Rename SchemaClassScanner.parameterize to withSealedTypeArguments.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Stacked on #857 so its review isn't mixed with this cleanup. Merge after #857, or retarget to
masteronce it's in.#857 added a lot of comments that say what the code right below already says, explain why we wrote our own code that way, or give history ("as before", "used to run on the first query"). That reasoning belongs in the PR, not the code, so this removes them. Same for issue links in the tests that only record where a fixture came from.
Comments about things we can't change stay: javac, Jackson, JDK proxies, kotlin-reflect and the graphql-java 25 vs 26 nullability difference. So do the 15.0.0 TODOs and the public API docs.
The only code change is renaming the private
SchemaClassScanner#parameterizetowithSealedTypeArguments, since the old name didn't say what it parameterizes with.mvn clean verifypasses on JDK 25.