Make task status service aware of current user#2756
Conversation
84e45a9 to
2f3a44c
Compare
e21a7e2 to
1b7128b
Compare
1b7128b to
8726c1c
Compare
stephencdaly
left a comment
There was a problem hiding this comment.
Changes look good and the bug is fixed.
Do you reckon it's worth adding a test for the scenario where the user enters a non-government email in the Welsh translations to check that the validation passes to prevent a regression?
8726c1c to
2a00405
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2756.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
|
@stephencdaly good shout, I've added a test for that now |
What problem does this pull request solve?
Trello card: No card for main change, but also includes https://trello.com/c/TVN9BNxQ/3448-refactor-formtaskstatusservice-to-use-dependency-injection
Passes the current user to the task status service. This follows the work in #2745 so that the task statuses are consistent everywhere.
This resolves an issue we were seeing where:
Also includes a factory change to make testing Welsh forms easier (cherry-picked from #2717)
Things to consider when reviewing