Skip to content

test: pin guidance on a failed tool's result - #58

Draft
vitaliyslion wants to merge 1 commit into
mainfrom
test/daemon-down-notice
Draft

vitaliyslion wants to merge 1 commit into
mainfrom
test/daemon-down-notice

Conversation

@vitaliyslion

Copy link
Copy Markdown
Collaborator

Summary

Tells the model once per session when the Gortex daemon is down, matching Claude Code. The notice comes from Gortex as a tool_call decision's additional_context (zzet/gortex#1284), which the extension already appends to that call's result, so no source change is needed here.

During an outage the graph call itself fails, so this adds a suite case pinning that guidance also joins a failed call's result. Pi runs tool_result handlers for failed tools too.

Depends on zzet/gortex#1284. Against a Gortex without it, a call during an outage gets an empty decision and the model hears nothing, as today. Merge after a Gortex release ships #1284.

Closes #49

Testing

  • npm run check passes
  • New behaviour has a suite that drives it through Pi's ExtensionRunner (see docs/tests.md)
  • Tried by hand in Pi (pi -e /path/to/checkout), if user-visible

Also verified outside the harness: a real Pi AgentSession with a scripted model, the extension spawning a locally built Gortex with #1284. After the hook was pointed at a dead daemon socket mid-session, the first indexed read's result carried the notice and the second carried nothing. With released Gortex both results carried nothing.

Checklist

  • No runtime dependencies added
  • README configuration table updated, if config changed
  • docs/architecture.md updated briefly, only if a design decision changed
  • Works on Windows paths and process spawning, if touching either

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tell the model once per session when the Gortex daemon is down

1 participant