Repository navigation
test: pin guidance on a failed tool's result - #58
Draft
vitaliyslion wants to merge 1 commit into
Draft
vitaliyslion wants to merge 1 commit into
vitaliyslion wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tells the model once per session when the Gortex daemon is down, matching Claude Code. The notice comes from Gortex as a
tool_calldecision'sadditional_context(zzet/gortex#1284), which the extension already appends to that call's result, so no source change is needed here.During an outage the graph call itself fails, so this adds a suite case pinning that guidance also joins a failed call's result. Pi runs
tool_resulthandlers for failed tools too.Depends on zzet/gortex#1284. Against a Gortex without it, a call during an outage gets an empty decision and the model hears nothing, as today. Merge after a Gortex release ships #1284.
Closes #49
Testing
npm run checkpassesExtensionRunner(seedocs/tests.md)pi -e /path/to/checkout), if user-visibleAlso verified outside the harness: a real Pi
AgentSessionwith a scripted model, the extension spawning a locally built Gortex with #1284. After the hook was pointed at a dead daemon socket mid-session, the first indexed read's result carried the notice and the second carried nothing. With released Gortex both results carried nothing.Checklist
docs/architecture.mdupdated briefly, only if a design decision changed