Conversation
|
Warning Review limit reachedNext included review available in 22 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #121
What
Why
godmin takes react-router as a peer, so pnpm keys godmin's identity on that version. With the pins apart, frontend resolved godmin built against 1.170.32 and sdk/frontend one built against 1.170.24. setViewport wrote the viewport of one instance while the shell read the other, so no menu button ever appeared on a narrow viewport. Aligning the pins collapses godmin back to a single copy and fixes all four viewport tests.
route-pending asserts a lazy route component exposes preload. Routes are module level constants and other tests warm PostsScreen, after which a resolved lazy component no longer carries preload, so with isolate false the result followed file order. Its own worker gives it a fresh module registry, which is what moduleStateFiles already exists for.
Testing
Note
This unblocks the react-router half of #118. Rebase that PR after this merges.
Greptile Summary
Aligns the frontend and SDK on
@tanstack/react-router1.170.32 so@gopherium/godminresolves against one router instance.route-pending.test.tsxinto the isolated Vitest project to prevent shared module state from affecting it.Confidence Score: 5/5
The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking issues identified.
The dependency graph consistently resolves one router copy, all declared Node targets satisfy the unchanged engine requirement, and the moved test remains included exactly once with the shared test configuration inherited.
Reviews (1): Last reviewed commit: "test(frontend): give the route pending t..." | Re-trigger Greptile