Skip to content

Keep godmin to one copy and isolate the route pending test - #122

Merged
SirLouen merged 2 commits into
mainfrom
fix/121
Aug 26, 2026
Merged

Keep godmin to one copy and isolate the route pending test#122
SirLouen merged 2 commits into
mainfrom
fix/121

Conversation

@SirLouen

@SirLouen SirLouen commented Aug 26, 2026

Copy link
Copy Markdown
Member

Closes #121

What

  • frontend and sdk/frontend move to @tanstack/react-router 1.170.32 together.
  • route-pending joins the test files that run in their own worker.

Why

godmin takes react-router as a peer, so pnpm keys godmin's identity on that version. With the pins apart, frontend resolved godmin built against 1.170.32 and sdk/frontend one built against 1.170.24. setViewport wrote the viewport of one instance while the shell read the other, so no menu button ever appeared on a narrow viewport. Aligning the pins collapses godmin back to a single copy and fixes all four viewport tests.

route-pending asserts a lazy route component exposes preload. Routes are module level constants and other tests warm PostsScreen, after which a resolved lazy component no longer carries preload, so with isolate false the result followed file order. Its own worker gives it a fresh module registry, which is what moduleStateFiles already exists for.

Testing

  1. In frontend, run pnpm run cover. 777 tests pass at the 100% thresholds.
  2. Run npx vitest run twice. 777 pass both times, where before the failure count moved between two and six across runs.
  3. Run npx tsc -b --force, and from the root pnpm -w lint, pnpm peers check and pnpm exec knip. All clean.

Note

This unblocks the react-router half of #118. Rebase that PR after this merges.

Greptile Summary

Aligns the frontend and SDK on @tanstack/react-router 1.170.32 so @gopherium/godmin resolves against one router instance.

  • Updates the router and associated transitive lockfile resolutions.
  • Moves route-pending.test.tsx into the isolated Vitest project to prevent shared module state from affecting it.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking issues identified.

The dependency graph consistently resolves one router copy, all declared Node targets satisfy the unchanged engine requirement, and the moved test remains included exactly once with the shared test configuration inherited.

Reviews (1): Last reviewed commit: "test(frontend): give the route pending t..." | Re-trigger Greptile

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 22 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4aa887aa-8c8e-47d8-acce-ab167bbf99bc

📥 Commits

Reviewing files that changed from the base of the PR and between d7d8cba and 497e44f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • frontend/package.json
  • frontend/vite.config.ts
  • sdk/frontend/package.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@SirLouen
SirLouen merged commit 1ff9e8f into main Aug 26, 2026
9 checks passed
@SirLouen
SirLouen deleted the fix/121 branch August 26, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep godmin to one copy and isolate the route pending test

1 participant