Skip to content

impl(showcase): regenerate showcase to use new streaming constructors - #6310

Open
suzmue wants to merge 1 commit into
googleapis:mainfrom
suzmue:regenerate-showcase-streaming
Open

impl(showcase): regenerate showcase to use new streaming constructors#6310
suzmue wants to merge 1 commit into
googleapis:mainfrom
suzmue:regenerate-showcase-streaming

Conversation

@suzmue

@suzmue suzmue commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

The integration test also needs to be updated due to the eager initialization changes.

For #2318

@suzmue
suzmue requested review from a team as code owners August 7, 2026 21:33

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the bidirectional streaming APIs (chat and connect) in the generated showcase client. It replaces the build method on request builders with a send method returning a Result, introduces fluent request setter methods, and updates the underlying stub, tracing, and transport layers to accept the initial request parameter and return a Result. The transport implementation has also been simplified to use RequestSender::from_fn and ResponseReceiver::from_stream instead of spawning a background task. I have no feedback to provide.

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.27%. Comparing base (516e38e) to head (e95340b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6310   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files         283      283           
  Lines       73110    73110           
=======================================
  Hits        70384    70384           
  Misses       2726     2726           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants