Skip to content

impl(bigquery): wire up QueryCreationMetadata - #6309

Draft
alvarowolfx wants to merge 1 commit into
googleapis:mainfrom
alvarowolfx:impl-bq-creation-metadata
Draft

impl(bigquery): wire up QueryCreationMetadata#6309
alvarowolfx wants to merge 1 commit into
googleapis:mainfrom
alvarowolfx:impl-bq-creation-metadata

Conversation

@alvarowolfx

Copy link
Copy Markdown
Contributor

Wire up generated QueryCreationMetadata and use it internally. Query::metadata() to be added in a future PR, since we are probably gonna remove query_reference.

Towards #5844

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Aug 7, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Query and CompleteQuery structures in the BigQuery crate to utilize the newly introduced QueryCreationMetadata instead of storing raw Job and QueryResponse objects. The rows field has been removed from QueryCreationMetadata (and updated in librarian.yaml), with query results now cached separately as cached_rows using a VecDeque. Additionally, helper constructors like from_job and from_query_response have been introduced, and associated tests have been updated to reflect these structural changes. There are no review comments provided, so I have no further feedback to offer.

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.84615% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.24%. Comparing base (c760f4c) to head (64298f8).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/bigquery/src/query/query_handle.rs 92.07% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6309      +/-   ##
==========================================
- Coverage   96.25%   96.24%   -0.01%     
==========================================
  Files         283      283              
  Lines       72936    72956      +20     
==========================================
+ Hits        70207    70219      +12     
- Misses       2729     2737       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant