Skip to content

feat(google-maps-routeoptimization-v1): onboard new client library - #6301

Open
noahdietz wants to merge 1 commit into
mainfrom
onboard-routeoptimization
Open

feat(google-maps-routeoptimization-v1): onboard new client library#6301
noahdietz wants to merge 1 commit into
mainfrom
onboard-routeoptimization

Conversation

@noahdietz

Copy link
Copy Markdown
Contributor

On one field, the way the proto documentation is line-wrapped after sanitization (proto) resulted in code that didn't compile. Using the documentation override feature to reformat one comment.

Towards googleapis/librarian#6594

@noahdietz
noahdietz requested review from a team as code owners August 6, 2026 20:02

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the new generated client library for the Google Maps Route Optimization API (google-maps-routeoptimization-v1), integrating it into the workspace and configuring documentation overrides. Feedback on the changes highlights a typo in the generated documentation for optimize_tours_uri in client.rs, which incorrectly references OptimizeToursLongRunningMetadata instead of OptimizeToursUriMetadata. A configuration override in librarian.yaml was suggested to resolve this issue.

Comment thread src/generated/maps/routeoptimization/v1/src/client.rs
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.25%. Comparing base (ecd5aeb) to head (a14774e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6301   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files         280      280           
  Lines       72194    72194           
=======================================
  Hits        69488    69488           
  Misses       2706     2706           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan closed this Aug 7, 2026
@coryan coryan reopened this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants