impl(bigquery): add attach_job method to query client - #6295
Open
haphungw wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to configure a default Google Cloud project ID on the BigQuery client and adds an attach_job method to bind existing out-of-process query jobs. The feedback recommends refactoring the nested if-else block in attach_job using Rust's let-else syntax to reduce indentation, and replacing .unwrap() calls with .expect() in the new unit tests to adhere to the repository's style guide.
haphungw
force-pushed
the
feat-bq-attach-job
branch
from
August 5, 2026 22:02
9ebfb67 to
f6fa4f4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6295 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 283 283
Lines 73009 73083 +74
=======================================
+ Hits 70279 70353 +74
Misses 2730 2730 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
haphungw
force-pushed
the
feat-bq-attach-job
branch
from
August 7, 2026 21:42
f6fa4f4 to
7f66bb6
Compare
haphungw
marked this pull request as ready for review
August 7, 2026 21:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
BigQuery::attach_jobto bind an existing out-of-process query job reference (JobReference) to a high-levelQueryhandle without re-submitting SQL.