Skip to content

impl(bigquery): add attach_job method to query client - #6295

Open
haphungw wants to merge 1 commit into
googleapis:mainfrom
haphungw:feat-bq-attach-job
Open

impl(bigquery): add attach_job method to query client#6295
haphungw wants to merge 1 commit into
googleapis:mainfrom
haphungw:feat-bq-attach-job

Conversation

@haphungw

@haphungw haphungw commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Add BigQuery::attach_job to bind an existing out-of-process query job reference (JobReference) to a high-level Query handle without re-submitting SQL.

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Aug 5, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to configure a default Google Cloud project ID on the BigQuery client and adds an attach_job method to bind existing out-of-process query jobs. The feedback recommends refactoring the nested if-else block in attach_job using Rust's let-else syntax to reduce indentation, and replacing .unwrap() calls with .expect() in the new unit tests to adhere to the repository's style guide.

Comment thread src/bigquery/src/client.rs
Comment thread src/bigquery/src/client.rs Outdated
Comment thread src/bigquery/src/client.rs Outdated
@haphungw
haphungw force-pushed the feat-bq-attach-job branch from 9ebfb67 to f6fa4f4 Compare August 5, 2026 22:02
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.26%. Comparing base (e71018a) to head (7f66bb6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6295   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         283      283           
  Lines       73009    73083   +74     
=======================================
+ Hits        70279    70353   +74     
  Misses       2730     2730           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haphungw
haphungw force-pushed the feat-bq-attach-job branch from f6fa4f4 to 7f66bb6 Compare August 7, 2026 21:42
@haphungw
haphungw marked this pull request as ready for review August 7, 2026 21:45
@haphungw
haphungw requested a review from a team as a code owner August 7, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant