Skip to content

feat(storage): enable CRC32C validation by default in transfer manager#8350

Draft
thiyaguk09 wants to merge 3 commits into
googleapis:mainfrom
thiyaguk09:feat/full-object-checksum-reads
Draft

feat(storage): enable CRC32C validation by default in transfer manager#8350
thiyaguk09 wants to merge 3 commits into
googleapis:mainfrom
thiyaguk09:feat/full-object-checksum-reads

Conversation

@thiyaguk09
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label May 22, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables CRC32C validation by default for the downloadFileInChunks method in the TransferManager class. It updates the DownloadFileInChunksOptions interface to accept boolean values, modifies the implementation to default to 'crc32c' validation, and ensures that validation is suppressed for individual sharded chunks to avoid redundant checks. The changes also include updated JSDoc documentation and comprehensive unit tests to verify the new default behavior and the ability to disable validation. Feedback was provided to update the JSDoc type for the validation property to use the specific 'crc32c' literal for consistency with the interface definition.

Comment thread handwritten/storage/src/transfer-manager.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant