feat(storage): enable CRC32C validation by default in transfer manager#8350
Draft
thiyaguk09 wants to merge 3 commits into
Draft
feat(storage): enable CRC32C validation by default in transfer manager#8350thiyaguk09 wants to merge 3 commits into
thiyaguk09 wants to merge 3 commits into
Conversation
…able it for individual shard downloads
…default handling logic
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables CRC32C validation by default for the downloadFileInChunks method in the TransferManager class. It updates the DownloadFileInChunksOptions interface to accept boolean values, modifies the implementation to default to 'crc32c' validation, and ensures that validation is suppressed for individual sharded chunks to avoid redundant checks. The changes also include updated JSDoc documentation and comprehensive unit tests to verify the new default behavior and the ability to disable validation. Feedback was provided to update the JSDoc type for the validation property to use the specific 'crc32c' literal for consistency with the interface definition.
…ng input to crc32c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕