Update formatter to handle Google email addresses with + signs#7
Open
lindsey-volta wants to merge 2 commits into
Open
Update formatter to handle Google email addresses with + signs#7lindsey-volta wants to merge 2 commits into
lindsey-volta wants to merge 2 commits into
Conversation
jradcliff
reviewed
Jun 1, 2026
| "Periods should be stripped from googlemail.com address", | ||
| ) | ||
|
|
||
| self.assertEqual( |
Member
There was a problem hiding this comment.
Could you use example emails from https://developers.google.com/style/examples#example-email-addresses instead?
Contributor
Author
There was a problem hiding this comment.
Updated to use the same sample emails from the documentation.
jradcliff
requested changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the email address has the gmail.com or googlemail.com domain, remove the plus sign from the username portion and all characters that follow it.