[exocrate] Re-export toml_const for parse_remote_archive - #3546
Open
Sagartaunk wants to merge 1 commit into
Open
[exocrate] Re-export toml_const for parse_remote_archive#3546Sagartaunk wants to merge 1 commit into
toml_const for parse_remote_archive#3546Sagartaunk wants to merge 1 commit into
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Update `parse_remote_archive` to call `toml_const` via `$crate::toml_const` instead of `::toml_const`. As, `toml_const` version `1.3.1` removes the need for downstream crates to depend on it solely to use the macro. Take advantage of this by dropping `toml_const` as a dependency from `anneal`. Fixes: google#3409
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3546 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 20 20
Lines 6093 6093
=======================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
parse_remote_archiveto calltoml_constvia$crate::toml_constinstead of::toml_const. As,toml_constversion1.3.1removes the need for downstream crates to depend on it solely to use the macro.Take advantage of this by dropping
toml_constas a dependency fromanneal.Fixes: #3409