Skip to content

Apply coverage ignore comments as applicable#287

Closed
Syed-Moiz-Ali wants to merge 2 commits into
google:masterfrom
Syed-Moiz-Ali:feat/coverage-ignore-comments
Closed

Apply coverage ignore comments as applicable#287
Syed-Moiz-Ali wants to merge 2 commits into
google:masterfrom
Syed-Moiz-Ali:feat/coverage-ignore-comments

Conversation

@Syed-Moiz-Ali

Copy link
Copy Markdown

Addresses #263

Adds // coverage:ignore-*\ annotations to exclude the following from coverage:

  • \ignore-file: all 14 impl_stub files + 3 generated files
  • \ignore-start/end:
    equireSubtleCrypto, \AlgorithmExtension.toJS, platform-specific \ hrow UnsupportedError\
  • \ignore-line: unreachable throws, trivial delegation factories/getters, conditional imports, OOM fallback, non-deterministic JS-interop paths

Adds // coverage:ignore-* annotations to code paths that are:
- JS-interop specific (requireSubtleCrypto, toJS bridges)
- Stub implementations (never executed in production)
- Generated files (symbols table, FFI bindings)
- Unreachable error paths (validation throws, fallback branches)
- Trivial delegation factories
- Platform-specific code branches
- OOM/infallible assertion paths

See: google#263
@google-cla

google-cla Bot commented Jun 16, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jonasfj

jonasfj commented Jun 22, 2026

Copy link
Copy Markdown
Member

Unrelated changes, PR must standalone.

@jonasfj jonasfj closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants