You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Moves the existing Flutter demo app out of example/ and into a named
subfolder, example/webcrypto_demo_flutter_app/, so that example/ can later
hold individual .dart snippet files for API documentation.
Folder name
Per the suggestion to consider the naming, I went with webcrypto_demo_flutter_app — it clearly distinguishes the full Flutter demo
app from the small doc snippets that will live alongside it in example/.
Commits
refactor: the move itself — 130 files, tracked by git as 100% renames
(no content changes), so history is preserved.
chore: fixes every reference to the old example/ path:
.github/workflows/test.yml — 6 working-directory / cd paths
example/webcrypto_demo_flutter_app/pubspec.yaml — path dependency ../ → ../../ (the app is one level deeper, so it must reach two levels
up to the repo root)
tool/test.sh, tool/clean.sh — local helper script paths
analysis_options.yaml — narrowed the lint exclude to the app subfolder so
future snippets in example/ remain analyzable
Sorry about the turnaround time, please do ping me when I forget.
I always have too many things cooking. @jonasfj
This was my first PR and I look forward contributing more, feeling good after my PR is merged. I'll keep checking but if you find or open any beginner level issues kindly tag me if you can , i'll be happy to contribute.
@Samarborkar we can probably find a lot more small things..
Especially, in the example space.
We should make sure all examples have static analysis.. ideally a form of testing.
We should make small examples for each and every method, lol 😂
Ideally, we should write tutorials and what not.
And there is still lots of testing to figure out. Exception testing, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #283.
Moves the existing Flutter demo app out of
example/and into a namedsubfolder,
example/webcrypto_demo_flutter_app/, so thatexample/can laterhold individual
.dartsnippet files for API documentation.Folder name
Per the suggestion to consider the naming, I went with
webcrypto_demo_flutter_app— it clearly distinguishes the full Flutter demoapp from the small doc snippets that will live alongside it in
example/.Commits
(no content changes), so history is preserved.
example/path:.github/workflows/test.yml— 6working-directory/cdpathsexample/webcrypto_demo_flutter_app/pubspec.yaml— path dependency../→../../(the app is one level deeper, so it must reach two levelsup to the repo root)
tool/test.sh,tool/clean.sh— local helper script pathsanalysis_options.yaml— narrowed the lint exclude to the app subfolder sofuture snippets in
example/remain analyzablenotes.md— updated a commented-out path reference