refactor: replace runtime symbol lookup with direct FFI bindings#279
Open
HamdaanAliQuatil wants to merge 3 commits into
Open
refactor: replace runtime symbol lookup with direct FFI bindings#279HamdaanAliQuatil wants to merge 3 commits into
HamdaanAliQuatil wants to merge 3 commits into
Conversation
jonasfj
reviewed
Jun 10, 2026
jonasfj
reviewed
Jun 22, 2026
jonasfj
left a comment
jonasfj
left a comment
Member
There was a problem hiding this comment.
Please outline how this works in the PR description
| ### List of BoringSSL symbols used | ||
| # This file is the source of truth for which BoringSSL symbols can be used from | ||
| # in the Dart code using`dart:ffi`. | ||
| # This file is the source of truth for which prefixed BoringSSL entry points |
Member
There was a problem hiding this comment.
Is this still true. What are we using this file for now?
jonasfj
reviewed
Jun 22, 2026
| return sizeof(CBB); | ||
| } | ||
|
|
||
| WEBCRYPTO_EXPORT void* webcrypto_get_EVP_PKEY_free_address(void) { |
Member
There was a problem hiding this comment.
Do we still need this hack? Or can we get the address from the ffigen bindings?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #277