fix(cloud): repoint 8 dead cloud.google.com doc links - #209
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
6e68625 to
252d71c
Compare
https://cloud.google.com/bigtable/docs/reference/sql returns 404. The GoogleSQL for Bigtable overview at https://cloud.google.com/bigtable/docs/googlesql-overview is the live page. Rebased onto current main: the other eight links this PR originally covered have since been fixed upstream, so only this one remains.
252d71c to
a2a1801
Compare
|
Rebased onto current Eight of the nine links this PR originally repointed have since been fixed upstream. The remaining one is in
I verified both with a request just now, and confirmed the dead link is still present at line 115 on The PR is now a single-line change and no longer conflicts. |
|
Thank you for flagging these broken links, @pucedoteth! We will be adding link-checking in regression tests soon. This is very helpful for the time being. |
Nine link occurrences across six skills return 404 on Google's current docs host. They sit in the "External Resources" / "Resources" sections these skills point an agent at, so an agent following them lands on a 404.
kubernetes-engine/docs/how-to/rollout-sequencingkubernetes-engine/docs/concepts/about-rollout-sequencingload-balancing/docs/overviewload-balancing/docs/load-balancing-overviewkubernetes-engine/docs/how-to/secret-manager×2secret-manager/docs/secret-manager-managed-csi-componentbinary-authorization/docs/getting-started-gkebinary-authorization/docs/setting-upkubernetes-engine/docs/concepts/sandboxkubernetes-engine/docs/concepts/sandbox-podskubernetes-engine/docs/how-to/pod-security-standardskubernetes-engine/docs/how-to/podsecurityadmissionbigtable/docs/reference/sqlbigtable/docs/googlesql-overviewalloydb/docs/reference/alloydb/docs/reference/restEach replacement was checked for a 200 and for a page title matching the existing link text — e.g.
secret-manager-managed-csi-componentrenders as "Use Secret Manager add-on with Google Kubernetes Engine", which covers both the "Secret Manager Add-on for GKE" and "Google Secret Manager CSI Driver" link texts, andbinary-authorization/docs/setting-uprenders as "Set up for GKE". After the change all 89cloud.google.comlinks underskills/resolve.Only link targets changed; no link text, prose, or code was touched.
Two notes:
skills/andplugins/. The only other failures were ~15registry.terraform.ioURLs, which are not broken — that host returns "Content not available in your region" for every path from my location, including its own root. I left those alone.Unrelated finding
skills/cloud/agent-platform-alert-configuration/scripts/analyze_traffic_test.pyfails for anyone outside Google: it reads mock data fromagent-platform-alert-configuration/_internal, which is not in the repo, not gitignored, and not a submodule, so all 12 of its cases error withFileNotFoundError. The other 13 Python test files pass. I did not touch it because the fix could be either publishing the fixtures or dropping the test, which is your call — happy to file it separately.