scan zip members by infolist instead of name - #42
Open
abdul-khaliq-khalid wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zip branch of
_extract_and_scan_archivewalkszf.namelist()and reopens each member withzf.open(name), but zipfile resolves a name throughNameToInfo, which only remembers the last entry carrying that name. So in an archive with two members calledmodel.pklthe second one gets read twice and the first one is never scanned: a zip holding a malicious pickle first and a benign dict second comes backunsafe: 0, while that same pickle alone in a zip comes backunsafe: 3. Opening theZipInfoobjects frominfolist()visits every member exactly once regardless of duplicate names, andutils.extract_zip_contentsenumerates the same way so it gets the same treatment.