Repository navigation
internal/graph: escape tag names in dot nodelets - #1054
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
Sample tag names may contain quotes, backslashes, or newlines (for example, structured database keys or raw string tags). When generating DOT nodelets, the unescaped tag names broke Graphviz syntax. Escape tag names with escapeForDot in addNodelets and numericNodelets, and add a regression test. Fixes google#769 Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample tag names can contain quotes, backslashes, or other characters that require escaping when emitted as string literals in DOT format (e.g. structured keys or custom application tags). Previously, .Name was interpolated directly into the nodelet DOT statement without escapeForDot(t.Name), causing Graphviz parsing errors when rendering the profile graph.
This PR wraps .Name in escapeForDot in �ddNodelets and
umericNodelets within internal/graph/dotgraph.go, and adds regression test coverage in internal/graph/dotgraph_test.go.
Fixes #769