Skip to content

internal/driver: create temp files with owner-only permissions #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ubeddulla wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −1
Open

internal/driver: create temp files with owner-only permissions #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccca0b5
internal/driver: create temp files with owner-only permissions
ubeddulla Oct 15, 2026
40f3d3f
internal/driver: fold temp file permission check into TestNewTempFile
ubeddulla Oct 16, 2026
d4feeb1
Merge branch 'main' into tempfile-0600-perms
aalexand Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/driver/tempfile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import (
// newTempFile returns a new output file in dir with the provided prefix and suffix.
func newTempFile(dir, prefix, suffix string) (*os.File, error) {
for index := 1; index < 10000; index++ {
switch f, err := os.OpenFile(filepath.Join(dir, fmt.Sprintf("%s%03d%s", prefix, index, suffix)), os.O_RDWR|os.O_CREATE|os.O_EXCL, 0666); {
switch f, err := os.OpenFile(filepath.Join(dir, fmt.Sprintf("%s%03d%s", prefix, index, suffix)), os.O_RDWR|os.O_CREATE|os.O_EXCL, 0600); {
case err == nil:
return f, nil
case !os.IsExist(err):
Expand Down
8 changes: 8 additions & 0 deletions internal/driver/tempfile_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package driver

import (
"os"
"runtime"
"sync"
"testing"
)
Expand Down Expand Up @@ -45,6 +46,13 @@ func TestNewTempFile(t *testing.T) {
break
}
names[name] = true
// Temp files can hold profile data, so they must not be accessible
// by group or other users.
if fi, err := os.Stat(name); err != nil {
t.Errorf("Stat(%s): got error %v, want no error", name, err)
} else if perm := fi.Mode().Perm(); runtime.GOOS != "windows" && perm&0077 != 0 {
t.Errorf("temp file %s has mode %#o, want no group/other access", name, perm)
}
}
if err := cleanupTempFiles(); err != nil {
t.Errorf("cleanupTempFiles(): got error %v, want no error", err)
Expand Down
Loading