Add buildAll task and fix fragile builds#3077
Conversation
This commit adds the buildAll task to restore the existence of a target that builds everything, which was unintentionally removed when the default build was stripped down in PR google#3068. It also introduces necessary sequential constraints to the console-webapp build tasks to prevent parallel execution from corrupting the Angular CLI cache. Finally, it addresses paths for the newer Angular esbuild output and hardens the style injection in ConsoleScreenshotTest to prevent fragile test failures.
gbrodman
left a comment
There was a problem hiding this comment.
is there a corresponding change to run this in CI?
@gbrodman reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on CydeWeys).
CydeWeys
left a comment
There was a problem hiding this comment.
No, or at least not yet. Unclear if we actually need to run all this stuff for CI (it would just slow it down).
@CydeWeys made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on CydeWeys).
CydeWeys
left a comment
There was a problem hiding this comment.
(Of course we can always do so, or increase the scope of the targets run in Kokoro anyway, as necessary. Doesn't have to be the buildAll, could be build plus something else. We'll see.)
@CydeWeys made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on CydeWeys).
gbrodman
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on CydeWeys).
This commit adds the buildAll task to restore the existence of a target that builds everything, which was unintentionally removed when the default build was stripped down in PR #3068. It also introduces necessary sequential constraints to the console-webapp build tasks to prevent parallel execution from corrupting the Angular CLI cache. Finally, it addresses paths for the newer Angular esbuild output and hardens the style injection in ConsoleScreenshotTest to prevent fragile test failures.
This change is