Update CLI dependencies and fix ShellCommandTest#3074
Closed
CydeWeys wants to merge 2 commits into
Closed
Conversation
This commit relaxes the upper bounds on several dependencies that were previously hardcapped to specific versions: - com.google.protobuf to [3.25.5,) and [3.17.3,) - org.apache.beam to [2.72.0,) - io.github.ss-bhatt to [1.0.0,) - io.protostuff to [1.8.0,) - redis.clients:jedis to [7.4.1,) - org.junit.jupiter and org.junit.platform to [5.6.2,) and [1.6.2,) Note: org.hibernate.orm and jakarta.persistence remain capped at 7.3.4.Final and [3.2.0,4.0.0) due to backwards incompatible deprecations added in newer versions that break the build under -Werror. The lockfiles have been fully regenerated and all test suites ran successfully against the latest available transitive versions.
This commit relaxes the upper bounds on CLI dependencies (jcommander, jline, and jakarta.servlet): - org.jcommander to [2.0,) - org.jline to [3.0,) - jakarta.servlet to [6.0,) Upgrading to the modern versions of jline introduced a breaking change where DefaultParser().parse(line, line.length()) strips trailing spaces when using the default ParseContext.UNSPECIFIED. This caused the autocompletion to misbehave and tests to fail. This commit fixes ShellCommandTest.java by explicitly passing ParseContext.COMPLETE when parsing test strings to perfectly mimic the real-world JLine completion context.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Attention Required: Lockfile Detected
This pull request contains modifications to one or more *.lockfile files. Please confirm that you have run update_dependency.sh to push new dependencies to the private repo.
Someone with Admin role must manually dismiss this review before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit relaxes the upper bounds on CLI dependencies (jcommander, jline, and jakarta.servlet):
- org.jcommander to [2.0,)
- org.jline to [3.0,)
- jakarta.servlet to [6.0,)
This change is