Updated code to fix deepcopy mobly adb erros - #1009
Closed
nithinpa-prog wants to merge 1 commit into
Closed
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
nithinpa-prog
commented
Jun 5, 2026
nithinpa-prog
left a comment
nithinpa-prog
left a comment
Author
There was a problem hiding this comment.
@xpconanfan, Can you please review and approve this changes
xpconanfan
approved these changes
Jul 31, 2026
Collaborator
|
Approved. Please fix CLA and rebase before we can merge it. |
Collaborator
|
Closing due to lack of response. This is covered by #1022 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix deepcopy/pickle issues with Mobly ADB errors and VirtualHomeManager errors b/519404719
The AdbError and AdbTimeoutError classes in Mobly's adb.py were not correctly calling the superclass init, which can cause issues with deepcopy and pickling. This change updates their init methods to pass arguments to super().init().