[NFC] clarify the choices in blackbox_optimizers - #575
Open
mtrofin wants to merge 5 commits into
Open
Conversation
mtrofin
force-pushed
the
mtrofin/typing
branch
from
August 17, 2026 19:49
46ee489 to
5b45d32
Compare
mtrofin
marked this pull request as ready for review
August 17, 2026 19:49
boomanaiden154
previously approved these changes
Aug 17, 2026
mtrofin
force-pushed
the
mtrofin/typing
branch
from
August 17, 2026 22:13
73c5157 to
a922079
Compare
Mainly for type checkers or linters - they may believe (incorrectly) that `top_index` may be uninitialized.
Update filter_top_directions to rank antithetic pairs by max(R+, R-) instead of symmetric absolute difference |R+ - R-|, following the Augmented Random Search (ARS) standard (Mania et al., 2018). In non-smooth or bounded environments, large negative penalties (cliffs) produce massive absolute differences that dominate Top-K direction selection and displace directions that discover higher-reward peaks. Sorting by maximum reward focuses the update on the top-performing perturbations.
mtrofin
force-pushed
the
mtrofin/typing
branch
from
August 18, 2026 00:26
a922079 to
0aed8bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly for type checkers or linters - they may believe (incorrectly) that
top_indexmay be uninitialized.