Conversation
…ogle#320) - Add explicit annotations parameter across all 68 registered tools in server/secops/secops_mcp/tools/ - Classify destructive tools (delete_data_table_rows, delete_feed, delete_watchlist, disable_feed, generate_feed_secret, deactivate_parser) with readOnlyHint=False, destructiveHint=True - Classify additive/mutating tools with readOnlyHint=False, destructiveHint=False - Classify query, search, and validation tools with readOnlyHint=True - Document tool annotations and safety hints in server/secops/README.md - Add test_tool_annotations_unit.py verifying ToolAnnotations presence and hint values across all tools
- Add explicit annotations parameter across all tools in secops-soar (17 tools), gti (36 tools), and scc (6 tools) - Classify destructive operations (close_case, remove_case_tag) with readOnlyHint=False, destructiveHint=True - Classify additive/mutating operations with readOnlyHint=False, destructiveHint=False - Classify query and inspection operations with readOnlyHint=True - Document tool annotations and safety hints in README.md for secops-soar, gti, and scc - Add test_tool_annotations_unit.py test suites verifying ToolAnnotations presence and hint values for all three servers
dandye
marked this pull request as draft
September 25, 2026 16:37
dandye
marked this pull request as ready for review
September 25, 2026 16:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves issue #320 by adding explicit FastMCP
annotations(readOnlyHint,destructiveHint) across all MCP servers in the repository:google-secops-mcp(68 tools)secops-soar-mcp(17 tools)gti-mcp(36 tools)scc-mcp(6 tools)Total: 127 tools annotated across all 4 servers.
Fixes #320
Background & Motivation
Model Context Protocol (MCP) clients, autonomous agents, and orchestrators (e.g. Gemini CLI, ADK, Claude, ChatGPT) rely on
ToolAnnotationshints to evaluate tool safety prior to execution:readOnlyHint: true: Allows clients to auto-approve safe queries without interactive confirmation prompts.readOnlyHint: false, destructiveHint: false: Signals additive / mutating operations that create or update resources without deleting state.readOnlyHint: false, destructiveHint: true: Signals high-impact operations that permanently remove resources or disrupt data collection, prompting clients for explicit user confirmation.Changes Made
1.
google-secops-mcp(68 tools across 17 modules)readOnlyHint: false, destructiveHint: true):delete_data_table_rows,delete_feed,disable_feed,generate_feed_secret,delete_watchlist,deactivate_parser.readOnlyHint: false, destructiveHint: false):create_rule,create_retrohunt,create_feed,update_feed,enable_feed,create_data_table,add_rows_to_data_table,create_reference_list,update_reference_list,create_rule_exclusion,patch_rule_exclusion,update_rule_exclusion_deployment,create_watchlist,update_watchlist,create_parser,activate_parser,ingest_raw_log,ingest_udm_events,do_update_security_alert,trigger_investigation,update_curated_rule_set_deployment.readOnlyHint: true): All 41 remaining query, search, and validation tools.2.
secops-soar-mcp(17 tools incase_management.py)readOnlyHint: false, destructiveHint: true):close_case,remove_case_tag.readOnlyHint: false, destructiveHint: false):create_case,post_case_comment,change_case_priority,update_case_description,assign_case,change_case_stage,add_case_tag.readOnlyHint: true):list_cases,list_alerts_by_case,list_alert_group_identifiers_by_case,list_events_by_alert,get_entities_by_alert_group_identifiers,get_entity_details,search_entity,get_case_full_details.3.
gti-mcp(36 tools across 6 modules)readOnlyHint: false, destructiveHint: false):create_collection,update_collection_attributes,update_iocs_in_collection,analyse_file.readOnlyHint: true): All 32 threat reporting, entity lookup, IOC search, domain/IP intelligence, threat profile, and hunting ruleset query tools.4.
scc-mcp(6 tools inscc_mcp.py)readOnlyHint: false, destructiveHint: false):set_finding_mute.readOnlyHint: true):search_findings,get_finding_details,search_findings_by_compliance,top_vulnerability_findings,get_finding_remediation.5. Documentation
Tool Annotations & Safety Hintssection toREADME.mdinserver/secops/,server/secops-soar/,server/gti/, andserver/scc/.6. Testing
test_tool_annotations_unit.pytest suites across all servers:server/secops/: 70 testsserver/secops-soar/: 19 testsserver/gti/: 38 testsserver/scc/: 8 tests