Repository navigation
Add Samsung SEF 3P plugin (JPEG SEFH/SEFT trailer and HEIC sefd box) - #11
Open
DichenZhang1 wants to merge 1 commit into
Open
DichenZhang1 wants to merge 1 commit into
DichenZhang1 wants to merge 1 commit into
Conversation
DichenZhang1
force-pushed
the
feat/plugin-samsung-sef
branch
from
October 12, 2026 21:37
7c433e0 to
645a4f2
Compare
DichenZhang1
force-pushed
the
feat/plugin-samsung-sef
branch
from
October 12, 2026 23:06
645a4f2 to
83fe572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
samsung_sef3P metadata provider plugin supporting Samsung Extended Format (SEF) Motion Photos across both JPEG (container.trailerwithSEFH/SEFT) and HEIC (heic.sefdbox paired withmpvd).Key Changes
lib/core/plugins/samsung_sef/):samsung_sef_metadata.proto: DefinesSamsungSefMetadata(sef_version,sef_entry_count,has_motion_photo_data,motion_photo_data_magic,video_offset,video_length,primary_image_timestamp_us,sef_keys).SamsungSefProvider: Parses backward-indexedSEFH/SEFTdirectories (v106 and v107), extractsMotionPhoto_Data(0x0A30), strips 12-bytempv2/mpv3headers in JPEG trailers to expose the exact embedded MP4 stream, and resolvesheic.sefdpointers to thempvdbox payload.HandlerOptions(disable_3p_plugins,enabled_3p_plugins) intoMetadataEngine::Parse.JpegContainerSplitterto inspect the 32-byte EOF tail and adjusttrailer_startto the earliest SEF record (sefh_offset - max_neg_offset) whenSEFTis present.HeifContainerSplitterto emitheic.sefdblocks with associatedmpvdbounds.samsung_sef_provider_test.cc):Identify,DecodeToSemantic,GetVideoInfo,IsMotionPhoto, SEF v106 (mpv2& raw MP4) and v107 (mpv3), HEICsefd+mpvdsplitting, primary image/video extraction,HandlerOptionsgating, and corrupted/overflow boundary safety.