control: Allow reconfiguring the save/restore exec binary - #14469
Open
tanyifeng wants to merge 1 commit into
Open
control: Allow reconfiguring the save/restore exec binary#14469tanyifeng wants to merge 1 commit into
tanyifeng wants to merge 1 commit into
Conversation
ConfigureSaveRestoreExec() rejected any call made when Kernel.SaveRestoreExecConfig was already set. The field is never cleared and is part of the saved kernel state, so checkpointing a sandbox a second time, or checkpointing a sandbox that was itself restored, always failed with "save/restore binary is already set". Replace the stored configuration instead, and always resolve the leader task again, since a task stored by an earlier call may have exited, in which case SaveRestoreExec() silently skips the hook. Assign the configuration only after the lookup succeeds, so a failed lookup no longer leaves behind a config with a nil LeaderTask. Add a test that checkpoints a sandbox twice and once more after a restore, asserting the hook runs every time. Signed-off-by: Tan Yifeng <yiftan@tencent.com>
tanyifeng
requested review from
EtiennePerot,
fvoznika and
nixprime
as code owners
August 28, 2026 04:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigureSaveRestoreExec() rejected any call made when Kernel.SaveRestoreExecConfig was already set. The field is never cleared and is part of the saved kernel state, so checkpointing a sandbox a second time, or checkpointing a sandbox that was itself restored, always failed with "save/restore binary is already set".
Replace the stored configuration instead, and always resolve the leader task again, since a task stored by an earlier call may have exited, in which case SaveRestoreExec() silently skips the hook. Assign the configuration only after the lookup succeeds, so a failed lookup no longer leaves behind a config with a nil LeaderTask.
Add a test that checkpoints a sandbox twice and once more after a restore, asserting the hook runs every time.