nvproxy: include ngx in "all" container driver capabilities - #14450
Merged
copybara-service[bot] merged 1 commit intoAug 28, 2026
Conversation
ayushr2
reviewed
Aug 27, 2026
ayushr2
reviewed
Aug 27, 2026
ayushr2
approved these changes
Aug 27, 2026
botirkhaltaev
marked this pull request as draft
August 27, 2026 16:30
botirkhaltaev
marked this pull request as ready for review
August 27, 2026 17:53
nvidia-container-toolkit's SupportedDriverCapabilities includes ngx, so NVIDIA_DRIVER_CAPABILITIES=all should pass --ngx to nvidia-container-cli and inject libnvidia-ngx. Assisted-by: Cursor
botirkhaltaev
force-pushed
the
botir/nvproxy-capngx
branch
from
August 27, 2026 17:54
e3803f0 to
551ba13
Compare
botirkhaltaev
changed the title
Collaborator
|
LGTM, can we have a Googler merge this? |
EtiennePerot
approved these changes
Aug 27, 2026
4 tasks
copybara-service Bot
pushed a commit
that referenced
this pull request
Aug 28, 2026
Omniverse / Isaac Sim RTX camera workloads initialize NGX (DLSS / Super Resolution) through `libnvidia-ngx`. If that library is not injected, Kit logs `NGX isn't enabled` / `Failed to create NGX context`, and the Vulkan device is often lost (`VkResult: ERROR_DEVICE_LOST`) while loading a scene with RTX cameras. nvproxy already has `CapNGX` as the nvidia-container-toolkit `ngx` flag (`--ngx` injects `libnvidia-ngx`). It is not a Resource Manager class and does not need a new ioctl. No handler in `version.go` is keyed on `CapNGX`. The gap is `AllContainerDriverCaps`: it did not include `CapNGX`, so `NVIDIA_DRIVER_CAPABILITIES=all` never passed `--ngx` to `nvidia-container-cli`. Toolkit's `SupportedDriverCapabilities` does include `ngx` (`compute,compat32,graphics,utility,video,display,ngx`). This change adds `CapNGX` to `AllContainerDriverCaps` only. `DefaultDriverCaps` stays `compute,utility`, so ngx remains off unless the container requests `all` or `ngx` and the runtime allows it. Split from the AMPERE_B ioctl work in #14449. Assisted-by: Cursor ## Test plan - [x] With `NVIDIA_DRIVER_CAPABILITIES=all`, `libnvidia-ngx` is injected - [x] Isaac Sim 5.1 headless RTX camera init no longer fails with `Failed to create NGX context` / `ERROR_DEVICE_LOST` once ngx is included in `all` - [ ] Default capabilities (`compute,utility`) still do not pass `--ngx` - [ ] No RM allocation/class changes; independent of #14449 FUTURE_COPYBARA_INTEGRATE_REVIEW=#14450 from botirkhaltaev:botir/nvproxy-capngx 551ba13 PiperOrigin-RevId: 972216146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Omniverse / Isaac Sim RTX camera workloads initialize NGX (DLSS / Super Resolution) through
libnvidia-ngx. If that library is not injected, Kit logsNGX isn't enabled/Failed to create NGX context, and the Vulkan device is often lost (VkResult: ERROR_DEVICE_LOST) while loading a scene with RTX cameras.nvproxy already has
CapNGXas the nvidia-container-toolkitngxflag (--ngxinjectslibnvidia-ngx). It is not a Resource Manager class and does not need a new ioctl. No handler inversion.gois keyed onCapNGX.The gap is
AllContainerDriverCaps: it did not includeCapNGX, soNVIDIA_DRIVER_CAPABILITIES=allnever passed--ngxtonvidia-container-cli. Toolkit'sSupportedDriverCapabilitiesdoes includengx(compute,compat32,graphics,utility,video,display,ngx).This change adds
CapNGXtoAllContainerDriverCapsonly.DefaultDriverCapsstayscompute,utility, so ngx remains off unless the container requestsallorngxand the runtime allows it.Split from the AMPERE_B ioctl work in #14449.
Assisted-by: Cursor
Test plan
NVIDIA_DRIVER_CAPABILITIES=all,libnvidia-ngxis injectedFailed to create NGX context/ERROR_DEVICE_LOSTonce ngx is included inallcompute,utility) still do not pass--ngx