Repository navigation
refactor!: Rename RepositoryCreateForkOptions and RepositoryAddCollaboratorOptions to ...Request and pass them by value - #4607
Merged
gmlewis merged 2 commits intoOct 9, 2026
Conversation
…oratorOptions` fields pointers Updates google#3644
…laboratorOptions` to `...Request` and pass them by value Updates google#3644
gmlewis
added
NeedsReview
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4607 +/- ##
=======================================
Coverage 98.61% 98.61%
=======================================
Files 199 199
Lines 18675 18675
=======================================
Hits 18417 18417
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Oct 7, 2026
gmlewis
left a comment
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @JamBalaya56562!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Collaborator
|
Thank you, @Not-Dhananjay-Mishra! |
JamBalaya56562
deleted the
refactor/3644-repos-fork-collaborator-request-types
branch
October 9, 2026 15:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #3644
This converts two
RepositoriesServicebody types, removing 4 entries from theparamcheckexception lists in.golangci.yml(2 frombody-allowed-pointer-typesand 2 frombody-allowed-wrong-names), plus the 4structfieldallowed-tag-typesentries marked# TODO: Repositoriesthat belong to them.RepositoryCreateForkOptionsCreateForkRequestCreateForkRepositoryAddCollaboratorOptionsAddCollaboratorRequestAddCollaboratorThe first commit makes the fields pointers (
Organization,NameandDefaultBranchOnlyon the fork request;Permissionon the collaborator request), which clears the four# TODO: Repositoriesentries instructfield'sallowed-tag-types. All four properties are optional in the OpenAPI request schemas (neither schema has arequiredlist, and both request bodies are themselves optional).The method names already match the docs operations ("Create a fork", "Add a repository collaborator"), so no verb rename is needed.
BREAKING CHANGE:
RepositoryCreateForkOptionsandRepositoryAddCollaboratorOptionsare renamed toCreateForkRequestandAddCollaboratorRequest;RepositoriesService.CreateForkandRepositoriesService.AddCollaboratornow take them by value instead of by pointer;CreateForkRequest.Organization,CreateForkRequest.Name,CreateForkRequest.DefaultBranchOnlyandAddCollaboratorRequest.Permissionare now pointers.