Skip to content

cvdr list: fix wrong error displayed #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emaheuxPEREN wants to merge 2 commits into
base: main
Choose a base branch
from
Open

cvdr list: fix wrong error displayed #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
889b2ae
cvdr list: fix wrong error displayed
emaheuxPEREN Sep 23, 2026
9f47569
CI: update Bazel pubkey URL
emaheuxPEREN Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/presubmit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
- name: Checkout repository
uses: actions/checkout@a81bbbf8298c0fa03ea29cdc473d45769f953675 # aka v2
- name: Install dependencies
uses: actions/setup-go@v3

Check failure on line 19 in .github/workflows/presubmit.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

zizmor/unpinned-uses 

unpinned action reference: action is not pinned to a hash (required by blanket policy)

Check failure on line 19 in .github/workflows/presubmit.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

unpinned-uses 

presubmit.yaml:19: unpinned action reference: action is not pinned to a hash (required by blanket policy)
with:
go-version: 1.23.4
- run: go version
Expand All @@ -29,7 +29,7 @@
- name: Vet
run: go vet ./...
- name: Staticcheck
uses: dominikh/staticcheck-action@v1.3.1

Check failure on line 32 in .github/workflows/presubmit.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

zizmor/unpinned-uses 

unpinned action reference: action is not pinned to a hash (required by blanket policy)

Check failure on line 32 in .github/workflows/presubmit.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

unpinned-uses 

presubmit.yaml:32: unpinned action reference: action is not pinned to a hash (required by blanket policy)
with:
version: "latest"
install-go: false
Expand Down Expand Up @@ -106,13 +106,13 @@
docker pull ${IMAGE_TAG}
echo "orchestration_image_tag=${IMAGE_TAG}" >> $GITHUB_ENV
- name: Download cuttlefish-cloud-orchestrator
uses: actions/download-artifact@7a1cd3216ca9260cd8022db641d960b1db4d1be4 # aka v4.0.0

Check failure on line 109 in .github/workflows/presubmit.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

zizmor/known-vulnerable-actions 

action has a known vulnerability: GHSA-cxww-7g56-2vh6

Check failure on line 109 in .github/workflows/presubmit.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

known-vulnerable-actions 

presubmit.yaml:109: action has a known vulnerability: GHSA-cxww-7g56-2vh6
with:
name: cuttlefish-cloud-orchestrator-amd64
- name: Load and run cuttlefish-cloud-orchestrator
run: |
docker load --input cuttlefish-cloud-orchestrator.tar
sed -i "s|DockerImageName = .*|DockerImageName = \"${{ env.orchestration_image_tag }}\"|g" \

Check failure on line 115 in .github/workflows/presubmit.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

zizmor/template-injection 

code injection via template expansion: may expand into attacker-controllable code

Check failure on line 115 in .github/workflows/presubmit.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

template-injection 

presubmit.yaml:115: code injection via template expansion: may expand into attacker-controllable code
scripts/on-premises/single-server/conf.toml
docker run -d \
-p 8080:8080 \
Expand All @@ -121,7 +121,7 @@
-v /var/run/docker.sock:/var/run/docker.sock \
-t cuttlefish-cloud-orchestrator
- name: Download cuttlefish-cvdremote
uses: actions/download-artifact@7a1cd3216ca9260cd8022db641d960b1db4d1be4 # aka v4.0.0

Check failure on line 124 in .github/workflows/presubmit.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

zizmor/known-vulnerable-actions 

action has a known vulnerability: GHSA-cxww-7g56-2vh6

Check failure on line 124 in .github/workflows/presubmit.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

known-vulnerable-actions 

presubmit.yaml:124: action has a known vulnerability: GHSA-cxww-7g56-2vh6
with:
name: cuttlefish-cvdremote-amd64
- name: Install cuttlefish-cvdremote
Expand All @@ -129,7 +129,7 @@
- name: Install bazel
run: |
sudo apt-get update && sudo apt-get install -y apt-transport-https curl gnupg
curl -fsSL https://bazel.build/bazel-release.pub.gpg | gpg --dearmor >bazel-archive-keyring.gpg
curl -fsSL https://releases.bazel.build/bazel-release.pub.gpg | gpg --dearmor >bazel-archive-keyring.gpg
mv bazel-archive-keyring.gpg /usr/share/keyrings
echo "deb [arch=amd64 signed-by=/usr/share/keyrings/bazel-archive-keyring.gpg] https://storage.googleapis.com/bazel-apt stable jdk1.8" | sudo tee /etc/apt/sources.list.d/bazel.list
sudo apt-get update && sudo apt-get install -y bazel zip unzip
Expand Down
2 changes: 1 addition & 1 deletion pkg/cli/cvd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ func listCVDs(srvClient client.Client, controlDir string) ([]*RemoteHost, error)
hostName := hosts[i]
listResult := <-ch
if listResult.Error != nil {
merr = multierror.Append(merr, fmt.Errorf("lists cvds for host %q failed: %w", hostName, err))
merr = multierror.Append(merr, fmt.Errorf("lists cvds for host %q failed: %w", hostName, listResult.Error))
continue
}
srvURL, err := srvClient.HostServiceURL(hostName)
Expand Down
Loading