Repository navigation
Conversation
avelad
commented
Oct 22, 2026
avelad
commented
- Add ChapterInformation interface and ChapterInformationInit dictionary
- Add chapterInfo to MediaMetadata and MediaMetadataInit
- Add MediaSessionEnterPictureInPictureReason typedef
- Add enterPictureInPictureReason and isActivating to MediaSessionActionDetails
- Add setScreenshareActive to MediaSession and update setCameraActive/setMicrophoneActive to return !Promise
- Maintain all spec URLs with https://wicg.github.io/mediasession/
- Add ChapterInformation interface and ChapterInformationInit dictionary - Add chapterInfo to MediaMetadata and MediaMetadataInit - Add MediaSessionEnterPictureInPictureReason typedef - Add enterPictureInPictureReason and isActivating to MediaSessionActionDetails - Add setScreenshareActive to MediaSession and update setCameraActive/setMicrophoneActive to return !Promise<void> - Maintain all spec URLs with https://wicg.github.io/mediasession/
lauraharker
requested changes
Oct 22, 2026
lauraharker
left a comment
lauraharker
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Looks good besides the @see tag, pulled it into Google's repo & am running tests.
|
|
||
|
|
||
| /** | ||
| * @see https://wicg.github.io/mediasession/#the-chapterinformationinit-dictionary |
Contributor
There was a problem hiding this comment.
One small fix: the @see for ChapterInformationInit uses #the-chapterinformationinit-dictionary, which doesn't exist in the spec. Could you change it to https://w3c.github.io/mediasession/#dictdef-chapterinformationinit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.