Fix overflow/underflow detection in join_seconds#354
Open
derekmauro wants to merge 2 commits into
Open
Conversation
Improve the precision of overflow and underflow checks in the
`join_seconds` template function. Specifically:
- Use `int64_t` for intermediate subsecond calculations to prevent
premature overflow when the target representation type is small.
- Refine the underflow check to correctly handle boundary cases near
the minimum limit, avoiding unsafe subtraction.
- Handle cases where the duration denominator is larger than the maximum
limit of the representation type.
Fixes google#199
Contributor
|
@derekmauro ... Just a heads-up that I think I'll have some comments for this, but it might take me a day or two to formulate them. Thanks. |
Member
Author
|
@devbww - No problem. If you haven't figured it out yet, thanks to Mythos we are all inundated with bugs, and apparently I am not the only person with access. Take your time. |
Contributor
I had not figured it out, but I was beginning to wonder. Hopefully the pickings are getting slimmer. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the precision of overflow and underflow checks in the
join_secondstemplate function.int64_tfor intermediate subsecond calculations to prevent premature overflow when the target representation type is small.Fixes #199