Repository navigation
assemble_cvd: avoid repeated sparse super conversions - #3334
Open
zhangxp1998 wants to merge 1 commit into
Open
zhangxp1998 wants to merge 1 commit into
zhangxp1998 wants to merge 1 commit into
Conversation
zhangxp1998
force-pushed
the
optimize-super-repack
branch
from
October 10, 2026 04:47
22b4429 to
dc206b7
Compare
When repacking DLKM partitions, convert a sparse build super image directly into the per-instance raw image first. Both lpadd operations can then update that image in place instead of repeatedly converting the full super image between sparse and raw formats.
zhangxp1998
force-pushed
the
optimize-super-repack
branch
2 times, most recently
from
October 10, 2026 09:04
3b2d934 to
9659cd0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
super.imgdirectly as the per-instance raw image before replacing DLKM partitionssuper.imgacross resume when the base OS inputs are unchangedWhy
The previous repack flow copied the sparse build image and invoked
lpaddtwice. Each invocation converted the full super image to raw and back to sparse, after whichassemble_cvdconverted it to raw once more. Resume also deleted the resulting per-instance raw image and repeated this work.Creating the per-instance raw image first lets both
lpadd --replacecalls operate in place. Keeping that image on resume avoids the initial conversion on subsequent kernel/ramdisk repacks. Existing OS-input invalidation still decides when the preserved image is unsafe to reuse.Validation
bazel build //cuttlefish/host/commands/assemble_cvd:assemble_cvd