fix(chat): hide the trace UI when isTraceEnabled() is false - #537
Merged
copybara-service[bot] merged 1 commit intoSep 29, 2026
Merged
Conversation
The chat declared FeatureFlagService.isTraceEnabled() but never read it, so a host could not turn traces off: the Events/Traces toggle, the trace view and the event tab's associated spans always showed. When isTraceEnabled() is false: - the Events/Traces toggle is hidden; - the chat stays in the events view, ignoring a stored "traces" choice; - switchToTraceView() does nothing; - the event tab lists no associated spans, whose links open the trace view. The default FeatureFlagService returns true, so behavior is unchanged unless a host overrides it.
wyf7107
approved these changes
Sep 29, 2026
liao02x
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat declared FeatureFlagService.isTraceEnabled() but never read it, so a host could not turn traces off: the Events/Traces toggle, the trace view and the event tab's associated spans always showed.
When isTraceEnabled() is false:
The default FeatureFlagService returns true, so behavior is unchanged unless a host overrides it.