Fix: Rolling KV cache and top-k logit trimming (fixes #675)#698
Open
medmomoait wants to merge 1 commit into
Open
Fix: Rolling KV cache and top-k logit trimming (fixes #675)#698medmomoait wants to merge 1 commit into
medmomoait wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #675
Changes
1. ChatSampler — Rolling KV Cache (ring buffer)
Adds
rolling_cacheandrolling_cache_preserve_tokensoptions toChatSampler. When enabled, old tokens are evicted from the KV cachein a ring-buffer fashion before each turn, preventing context-exhaustion
OOM in long multi-turn conversations. A configurable prefix (e.g. system
prompt) can be protected from eviction.
2. SamplerLoop — Top-k logit trimming
Adds a
top_k_logitsoption toSamplerLoop. When set, logits aremasked to top-k immediately after the forward pass, reducing the
transient VRAM footprint during sampling without changing the sampling
distribution.
Both changes default to the previous behavior (disabled), so this is
backward compatible.