fix(t5gemma): add missing f-prefix in _normalize_token error message#697
Open
Osamaali313 wants to merge 1 commit into
Open
fix(t5gemma): add missing f-prefix in _normalize_token error message#697Osamaali313 wants to merge 1 commit into
Osamaali313 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot I signed it! |
The ValueError raised in t5gemma's _normalize_token used '{token!r}' inside a
plain string literal (no f-prefix), so the message printed the literal text
"{token!r}" instead of the offending token, making forbidden-token
misconfigurations hard to debug. Add the f-prefix so the token is interpolated.
Same bug class as google-deepmind#658 (gemma/gm/text/_sampler.py); this is the sibling
occurrence in gemma/research/t5gemma/sampling.py.
Osamaali313
force-pushed
the
fix/t5gemma-token-error-fstring
branch
from
f42e589 to
f94d016
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_normalize_token()ingemma/research/t5gemma/sampling.pyraises aValueErrorwhose message uses{token!r}inside a plain string literal (nofprefix), so users see the placeholder printed literally instead of the offending token:This makes
forbidden_tokensmisconfigurations hard to debug. Adding thefprefix interpolates the token as intended:Context
This is the same bug class as #658 (
gemma/gm/text/_sampler.py). A repo-wide sweep for non-f-string error messages containing{...}placeholders found exactly two occurrences — the one reported in #658, and this sibling inresearch/t5gemma/sampling.pywhich that report missed. This PR fixes the t5gemma occurrence.Change
One line: add the
fprefix to the string literal that contains{token!r}(the adjacent continuation line has no placeholder and is left unchanged).