Claude/review repo suggestions f8 qky#560
Open
Mweimar2000 wants to merge 8 commits intogoogle-ai-edge:mainfrom
Open
Claude/review repo suggestions f8 qky#560Mweimar2000 wants to merge 8 commits intogoogle-ai-edge:mainfrom
Mweimar2000 wants to merge 8 commits intogoogle-ai-edge:mainfrom
Conversation
…list, breathing exercise - unit-converter: converts between length, weight, temperature, speed, volume, and area units with no internet required - timezone-converter: converts times between IANA timezones using the device's built-in Intl API - todo-list: persistent on-device task manager with add/complete/delete/clear actions and a Webview UI - breathing-exercise: animated guided breathing with box, 4-7-8, and calm patterns and a visual circle UI All skills run fully on-device with no external APIs or internet required. https://claude.ai/code/session_018DoZ4jr65RELeDmExxCq7r
Built-in text-only skills (LLM-only, no scripts): - recipe-generator: suggest recipes from available ingredients - rhyme-generator: write poems, lyrics, and rap with rhymes - travel-planner: day-by-day itineraries for any destination - polite-rewriter: rephrase messages to be more professional or diplomatic - birthday-greeting: personalized birthday messages and card texts Built-in offline JS/Webview skills: - countdown-timer: animated ring countdown with label support - water-tracker: daily hydration log with goal and history (localStorage) - sleep-log: log bedtime/wake time, view history and averages (localStorage) - loan-calculator: monthly payment, total interest, and reverse loan calculation - expense-log: categorized spending tracker with summary view (localStorage) - shopping-list: persistent grocery list with check-off and clear-bought (localStorage) Featured skills using free APIs (no key required): - dictionary: word definitions, synonyms, pronunciation via dictionaryapi.dev - currency-converter: live exchange rates via frankfurter.app (30+ currencies) - book-finder: search books by title, author, or topic via Open Library https://claude.ai/code/session_018DoZ4jr65RELeDmExxCq7r
- Add MockK (1.13.12) and kotlinx-coroutines-test (1.9.0) to test dependencies
- Create app/src/test/ directory structure with 3 test classes (34 tests total):
- ModelTest: 22 tests covering normalizedName, preProcess (configValues + totalBytes),
getPath (all branches: override, imported, relativeDir, default, zip), and
getIntConfigValue / getFloatConfigValue / getBooleanConfigValue / getExtraDataFile
- TosViewModelTest: 8 tests verifying TosViewModel delegates correctly to
DataStoreRepository and that TOS/Gemma terms states are independent
- ExampleCustomTaskViewModelTest: 8 tests for StateFlow state management,
idempotency, and copy immutability
- Update build_android.yaml CI to run testDebugUnitTest before assembleRelease
and upload HTML test reports as a build artifact
https://claude.ai/code/session_018DoZ4jr65RELeDmExxCq7r
FcmMessagingService.kt: - Remove stale boilerplate TODO comment and unused handleNow() stub - Simplify onMessageReceived to only log data payloads and display notifications SecretEditorDialog.kt + strings.xml: - Add cd_show_password and cd_hide_password string resources - Replace hardcoded "Show password" / "Hide password" literals with stringResource() BenchmarkViewModel.kt: - Add errorMessage field to BenchmarkUiState - Wrap benchmark loop in try-catch: on failure, log the exception, clean up the cache directory, surface the error message in uiState, and return early - Add clearError() helper so the UI can dismiss the error - Clear errorMessage on successful completion DownloadRepository.kt: - Fix copy-paste bug: failure notification now uses notification_content_fail instead of notification_content_success - Replace android.R.drawable.ic_dialog_info placeholder with R.mipmap.ic_launcher - Add failure_reason field (first 100 chars of errorMessage) to the Firebase Analytics failure event, resolving the TODO: Add failure reasons comment https://claude.ai/code/session_018DoZ4jr65RELeDmExxCq7r
…ONDUCT.md, README update) - CONTRIBUTING.md: comprehensive guide covering skill contributions, Android development setup, architecture overview, PR process, and bug reporting - CODE_OF_CONDUCT.md: community standards adapted from Contributor Covenant 2.1 - README.md: new Contributing section linking to CONTRIBUTING.md, good first issues, skills docs, and Code of Conduct https://claude.ai/code/session_018DoZ4jr65RELeDmExxCq7r
- iOS/README.md: documents App Store installation, device requirements, supported models table (from ios_1_0_0.json), model allowlist JSON format, instructions for proposing new models via PR, feature parity table vs Android, and iOS bug reporting guide https://claude.ai/code/session_018DoZ4jr65RELeDmExxCq7r
- skills/index.json: machine-readable catalog of all 29 skills with metadata and GitHub Pages URLs, ready for future in-app discovery integration - skills/README.md: added all 17 new skills to Skill Examples section with type badges, plus a new "Load by URL" table showing GitHub Pages URLs for direct in-app loading after merge to main https://claude.ai/code/session_018DoZ4jr65RELeDmExxCq7r
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
- skills/featured/google-search/SKILL.md: skill definition with instructions for the LLM to extract queries and cite sources from results - skills/featured/google-search/scripts/index.html: JS skill that calls the Custom Search JSON API; handles the two required credentials (API key + Search Engine ID) as a single secret in the format API_KEY|CX_ID - skills/index.json: added google-search entry to the skills catalog The free tier allows 100 queries/day. Setup instructions are shown in the app's credential dialog (require-secret-description). https://claude.ai/code/session_018DoZ4jr65RELeDmExxCq7r
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.