Environment deletion#3466
Merged
Merged
Conversation
mschuwalow
commented
May 18, 2026
| FROM components c | ||
| JOIN component_revisions cr ON c.component_id = cr.component_id | ||
| WHERE c.component_id = $1 AND cr.revision_id = $2 AND ($3 OR c.deleted_at IS NULL) | ||
| JOIN environments e ON e.environment_id = c.environment_id |
Contributor
Author
There was a problem hiding this comment.
The semantics here changed such that include_deleted means "include if the entity itself is deleted, but still exclude it if any parent is deleted)
mschuwalow
force-pushed
the
environment-deletion
branch
from
aa6fe6b to
a7fb72c
Compare
vigoo
reviewed
May 18, 2026
| InitialAgentFileDownloadFailed initial_agent_file_download_failed = 24; | ||
| FileSystemError file_system_error = 25; | ||
| InvocationFailed invocation_failed = 26; | ||
| ComponentNotFound component_not_found = 5; |
Contributor
There was a problem hiding this comment.
The new WorkerExecutorError::ComponentNotFound is not handled in:
From<WorkerExecutorError>forApiEndpointError— falls through to INTERNAL_UNKNOWN (HTTP 500).From<WorkerServiceError>foragent_error::ErrorforGolemError(WorkerExecutorError::ComponentNotFound { .. })— falls through to InternalError.golem-worker-service/src/service/worker/routing_logic.rsshould likely treat it as Expected(...) so it isn't logged/metered as an internal failure.
Contributor
Author
There was a problem hiding this comment.
Done. This should normally not reach the worker service outside very specific timings (as the auth check will fail before it reaches the executor), but better to clean it up 👍
Contributor
|
I noticed that the |
vigoo
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that agents are properly stopped on environment deletion (not just component deletion).
This is a first step in allowing to investigate and shut down misbehaving applications as admins.