Skip to content

unix: add O_CLOFORK and related constants, support it in Dup3 - #266

Open
ricardobranco777 wants to merge 1 commit into
golang:masterfrom
ricardobranco777:oclofork
Open

ricardobranco777 wants to merge 1 commit into
golang:masterfrom
ricardobranco777:oclofork

Conversation

@ricardobranco777

@ricardobranco777 ricardobranco777 commented Dec 15, 2025 •

Copy link
Copy Markdown

POSIX.1-2024 adds close-on-fork: O_CLOFORK, FD_CLOFORK,
F_DUPFD_CLOFORK, SOCK_CLOFORK and MSG_CMSG_CLOFORK. Add them, along
with the system-specific F_DUP2FD_CLOFORK, F_DUP3FD and F_DUP3FD_SHIFT,
on the systems that implement them: FreeBSD 15.0, NetBSD 11.0,
OpenBSD 7.8, DragonFly BSD and illumos.

The zerrors files were edited by hand. mkerrors.sh already matches
these prefixes, so no generator change is needed. Regenerating would
require running each new release on every architecture and would pull
in many unrelated changes. The values were taken from these sources,
and are the same on every architecture of an OS:

FreeBSD    release/15.0.0  sys/sys/fcntl.h, sys/sys/socket.h
NetBSD     netbsd-11       sys/sys/fcntl.h, sys/sys/socket.h
OpenBSD    42a7be81bef7    sys/sys/fcntl.h, sys/sys/socket.h
DragonFly  dea249a60d18    sys/sys/fcntl.h, sys/sys/socket.h
illumos    3581f14f537c    uts/common/sys/fcntl.h, socket.h

The OpenBSD commit is the one that added close-on-fork, ahead of 7.8.

On FreeBSD and DragonFly, libc implements dup3 with F_DUP3FD and the
flags shifted by F_DUP3FD_SHIFT. Do the same in Dup3 when O_CLOFORK is
requested. Keep using F_DUP2FD and F_DUP2FD_CLOEXEC otherwise, so Dup3
keeps working on kernels without F_DUP3FD.

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: fadb71b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/730240.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/730240.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/730240.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Florian Lehner:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/730240.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 79a631b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/730240.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

POSIX.1-2024 adds close-on-fork: O_CLOFORK, FD_CLOFORK,
F_DUPFD_CLOFORK, SOCK_CLOFORK and MSG_CMSG_CLOFORK. Add them, along
with the system-specific F_DUP2FD_CLOFORK, F_DUP3FD and F_DUP3FD_SHIFT,
on the systems that implement them: FreeBSD 15.0, NetBSD 11.0,
OpenBSD 7.8, DragonFly BSD and illumos.

The zerrors files were edited by hand. mkerrors.sh already matches
these prefixes, so no generator change is needed. Regenerating would
require running each new release on every architecture and would pull
in many unrelated changes. The values were taken from these sources,
and are the same on every architecture of an OS:

	FreeBSD    release/15.0.0  sys/sys/fcntl.h, sys/sys/socket.h
	NetBSD     netbsd-11       sys/sys/fcntl.h, sys/sys/socket.h
	OpenBSD    42a7be81bef7    sys/sys/fcntl.h, sys/sys/socket.h
	DragonFly  dea249a60d18    sys/sys/fcntl.h, sys/sys/socket.h
	illumos    3581f14f537c    uts/common/sys/fcntl.h, socket.h

The OpenBSD commit is the one that added close-on-fork, ahead of 7.8.

On FreeBSD and DragonFly, libc implements dup3 with F_DUP3FD and the
flags shifted by F_DUP3FD_SHIFT. Do the same in Dup3 when O_CLOFORK is
requested. Keep using F_DUP2FD and F_DUP2FD_CLOEXEC otherwise, so Dup3
keeps working on kernels without F_DUP3FD.

Signed-off-by: Ricardo Branco <rbranco@suse.de>
@ricardobranco777 ricardobranco777 changed the title unix: Add O_CLOFORK & related constants unix: add O_CLOFORK and related constants, support it in Dup3 Oct 17, 2026
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: a8bfa09) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/730240.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants