Update create-replication-endpoints.md - #690
Merged
Merged
Conversation
[UPDATE: Fix Typo] - space missing Signed-off-by: Negin Kheirmand <neginkheirmand@gmail.com>
[fix typo]: Missing space Signed-off-by: Negin Kheirmand <neginkheirmand@gmail.com>
Contributor
Author
Vad1mo
approved these changes
Sep 20, 2026
Vad1mo
left a comment
Vad1mo
left a comment
Member
There was a problem hiding this comment.
Whitespace-only fix, correct. The create-replication-endpoints.md typo is still present on main.
The _index.md hunk is already on main via #699 (byte-identical), so it merges as a no-op. No rebase needed.
Follow-up, not this PR: "storage permission" is not an ECR concept. The adapter needs IAM actions for GetAuthorizationToken, DescribeRepositories and CreateRepository (src/pkg/reg/adapter/awsecr/auth.go:134, adapter.go:227,241).
Vad1mo
pushed a commit
that referenced
this pull request
Sep 20, 2026
Backport of the same fix as #690, against release-2.14.0. "password.The" -> "password. The", "storagepermission" -> "storage permission".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[UPDATE: Fix Typo] - space missing
This is the same fix as PR #689, opened against main as requested.