fix: struct-based TextureRegionUpdater.UpdateRegion (v0.31.1) - #35
Merged
Conversation
Replace six positional int parameters with struct-based API aligned with WebGPU GPUTexelCopyBufferLayout and Go image.Rectangle idiom (#484).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
5 tasks
Contributor
Author
|
CI green. Ready for review/merge — gogpu/gogpu#486 rebased onto this struct API (pseudo-version pin until v0.31.1 tag). |
kolkov
approved these changes
Aug 30, 2026
kolkov
left a comment
kolkov
left a comment
Contributor
There was a problem hiding this comment.
LGTM. ImageDataLayout struct matches WebGPU GPUTexelCopyBufferLayout at the app level. Three distinct parameter types eliminate silent int-swap bugs. Zero value correct. Clean patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateRegion(x, y, w, h, bytesPerRow, data)withUpdateRegion(region image.Rectangle, data, layout ImageDataLayout)gpucontext.ImageDataLayout(BytesPerRow, RowsPerImage, Offset)Test plan
go test ./...