Skip to content

fix(release): draft releases until assets are attached #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpage-godaddy merged 3 commits into from
Aug 12, 2026
+14 −2
Merged

fix(release): draft releases until assets are attached #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4f54ea
fix(release): draft releases until assets are attached
Swaagie Aug 11, 2026
083f63c
docs(release): trim workflow comments to terse why notes
Swaagie Aug 11, 2026
1c0fe1f
fix(release): publish_only fallback selects newest draft, fails if none
Swaagie Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,18 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
run: |
# Release is a draft (release-please-config.json) so `latest` never
# points at it until every asset is attached — avoids a 404 window.
TAG="${{ needs.release-please.outputs.tag_name }}"
if [ -z "$TAG" ]; then
TAG="$(gh release list --limit 1 --json tagName --jq '.[0].tagName')"
# publish_only retry path has no tag_name: pick the newest *draft*
# only (never a published release) and fail fast if none exists.
TAG="$(gh release list --limit 30 --json tagName,isDraft \
--jq 'map(select(.isDraft)) | .[0].tagName // empty')"
if [ -z "$TAG" ]; then
echo "No draft release found to publish." >&2
exit 1
fi
fi
gh release upload "$TAG" \
dist/gddy-*.tar.gz \
Expand All @@ -154,3 +163,5 @@ jobs:
install.sh \
install.ps1 \
--clobber
# Publish only now assets are complete; stays a draft if build fails.
gh release edit "$TAG" --draft=false --latest
3 changes: 2 additions & 1 deletion release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"rust": {
"release-type": "rust",
"component": "gddy",
"include-component-in-tag": false
"include-component-in-tag": false,
"draft": true
}
}
}
Loading